Fix markdown table parser consuming lines without pipes as table rows#1626
Merged
Fix markdown table parser consuming lines without pipes as table rows#1626
Conversation
The TableRow rule in the PEG grammar allowed rows with zero pipe characters (TableItem2*). This caused lines like `<br>` immediately following a table to be parsed as single-cell table rows, producing spurious `<td><br></td>` in the rendered HTML. Change TableItem2* to TableItem2+ so that rows not starting with `|` must contain at least one `|` to be recognized as table rows.
Collaborator
|
🚀 Preview deployment available at: https://3f1c100f.rdoc-6cd.pages.dev (commit: a757b75) |
Change TableAlign2* to TableAlign2+ in the TableLine rule for consistency with the TableRow fix. A separator line without any pipe character would conflict with horizontal rule parsing anyway.
Verify that a separator line with no pipe character does not form a valid table, matching the TableLine rule change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The TableRow rule in the PEG grammar allowed rows with zero pipe characters (
TableItem2*). This caused lines like<br>immediately following a table to be parsed as single-cell table rows, producing spurious<td><br></td>in the rendered HTML.Change
TableItem2*toTableItem2+so that rows not starting with|must contain at least one|to be recognized as table rows.