Stop generating a separate page file for main_page#1624
Merged
Conversation
When a page is used as main_page (e.g. README.md), its content is already displayed on index.html. Generating a separate page file (e.g. README_md.html) is redundant. Skip the main_page in: - darkfish generator (page file generation) - json search index (avoids linking to a nonexistent page) - aliki sidebar pages template
Collaborator
|
🚀 Preview deployment available at: https://6f944c09.rdoc-6cd.pages.dev (commit: e42e833) |
Member
|
<p>Please follow the theme’s <a href="README_md.html">README</a> for usage instructions.</p>
|
Member
|
Sorry, https://50c952f8.rdoc-6cd.pages.dev/README_md.html looks like a cached file, it's not generated. |
When a page is set as main_page, its content is displayed on index.html and no separate page file is generated. Update TopLevel#path to return index.html for the main_page so all consumers (cross-references, sidebar links, table of contents, search records) automatically generate correct links. Also tighten the generate_file_files skip to only apply to text pages, preventing accidental skipping if a source file is set as main_page.
Member
Author
|
@tompng Thanks, fixed |
tompng
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a page is used as
main_page(e.g.README.md), its content is already displayed on index.html. Generating a separate page file (e.g.README_md.html) is redundant.Skip the main_page in: