Skip to content

Avoid recomputing HMAC digests during comparison #1101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
OskarEichler wants to merge 1 commit into from
+5 −2
Closed

Avoid recomputing HMAC digests during comparison #1101

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions lib/openssl/hmac.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,12 @@ class HMAC
# Securely compare with another HMAC instance in constant time.
def ==(other)
return false unless HMAC === other
return false unless self.digest.bytesize == other.digest.bytesize

OpenSSL.fixed_length_secure_compare(self.digest, other.digest)
self_digest = digest
other_digest = other.digest
return false unless self_digest.bytesize == other_digest.bytesize

OpenSSL.fixed_length_secure_compare(self_digest, other_digest)
end

# :call-seq:
Expand Down