🧪 Add experimental new FakeServer for tests #157
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was written for several reasons:
yields_in_test_server_threadand clean up tests using it#capable?(name)#156OpenSSL::SSL::SSLSocket#accept, eventhough I copied and pasted from
imaps_testandstarttls_test. 😳I will (probably) eventually update most of the tests in
test_imap.rbto useFakeServer. The version here is able to support the capabilities tests and several more existing tests. To quote the rdoc:The following tests in
test_imap.rbhave been updated to useFakeServer:test_clear_responsestest_closetest_enabletest_responsestest_uid_expungetest_uidplus_responsestest_unselectAll of the tests that used
yields_in_test_server_threadwere updated, so that method was deleted too. It has effectively been replaced bywith_fake_server.