Skip to content

Preserve streaming response destinations with body encoding #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
OskarEichler wants to merge 1 commit into
base: master
Choose a base branch
from
+11 −10
Open

Preserve streaming response destinations with body encoding #338

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 11 additions & 10 deletions lib/net/http/response.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,16 +386,18 @@ def read_body(dest = nil, &block)
@read = true
return if @body.nil?

case enc = @body_encoding
when Encoding, false, nil
# Encoding: force given encoding
# false/nil: do not force encoding
else
# other value: detect encoding from body
enc = detect_encoding(@body)
end
if @body.respond_to?(:force_encoding)
case enc = @body_encoding
when Encoding, false, nil
# Encoding: force given encoding
# false/nil: do not force encoding
else
# other value: detect encoding from body
enc = detect_encoding(@body)
end

@body.force_encoding(enc) if enc
@body.force_encoding(enc) if enc
end

@body
end
Expand Down Expand Up @@ -753,4 +755,3 @@ def read_all dest
end

end