Skip to content

Optimize integration test performance #764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ydah wants to merge 1 commit into
base: master
Choose a base branch
from
+20 −4
Open

Optimize integration test performance #764

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 20 additions & 4 deletions spec/lrama/integration_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,12 @@

RSpec.describe "integration" do
module IntegrationHelper
@compiled_parsers = {}

class << self
attr_accessor :compiled_parsers
end

def exec_command(command)
`#{command}`
raise "#{command} failed." unless $?.success?
Expand Down Expand Up @@ -35,9 +41,14 @@ def test_parser(parser_name, input, expected, expect_success: true, lrama_comman
debug = true
end

Lrama::Command.new(%W[-H#{parser_h_path} -o#{parser_c_path}] + lrama_command_args + %W[#{grammar_file_path}]).run
exec_command("flex --header-file=#{lexer_h_path} -o #{lexer_c_path} #{lexer_file_path}")
exec_command("#{compiler} -Wall -ggdb3 -I#{tmpdir} #{parser_c_path} #{lexer_c_path} -o #{obj_path}")
cache_key = "#{parser_name}_#{lrama_command_args.join('_')}"

unless IntegrationHelper.compiled_parsers[cache_key] && File.exist?(obj_path)
Lrama::Command.new(%W[-H#{parser_h_path} -o#{parser_c_path}] + lrama_command_args + %W[#{grammar_file_path}]).run
exec_command("flex --header-file=#{lexer_h_path} -o #{lexer_c_path} #{lexer_file_path}")
exec_command("#{compiler} -Wall -O0 -g -I#{tmpdir} #{parser_c_path} #{lexer_c_path} -o #{obj_path}")
IntegrationHelper.compiled_parsers[cache_key] = true
end

out = err = status = nil

Expand All @@ -58,12 +69,17 @@ def test_parser(parser_name, input, expected, expect_success: true, lrama_comman

def generate_object(grammar_file_path, c_path, obj_path, command_args: [])
Lrama::Command.new(%W[-d -o #{c_path}] + command_args + %W[#{grammar_file_path}]).run
exec_command("#{compiler} -Wall #{c_path} -o #{obj_path}")
exec_command("#{compiler} -Wall -O0 #{c_path} -o #{obj_path}")
end
end

include IntegrationHelper

# Clear cache after all tests to save memory
after(:all) do
IntegrationHelper.compiled_parsers.clear
end

describe "calculator" do
it "returns 9 for '(1+2)*3'" do
test_parser("calculator", "( 1 + 2 ) * 3", "=> 9")
Expand Down