Repository navigation
Read the dir output for the symlink check as binary - #215
Merged
Merged
Conversation
cmd.exe writes it in the console code page, which is CP932 in an ssh session, while IO.popen tags it as UTF-8 on Windows, so the regexp match raised ArgumentError. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_ln_s_relative_to_symlinked_directoryfails withArgumentError: invalid byte sequence in UTF-8on mswin when the tests run over ssh. The console code page there is 932, socmd.exewrites thediroutput in CP932.IO.popentags that output as UTF-8 on Windows, and the<SYMLINKD>match raises.Reading it with
"rb"fixes that. This is a forward-port of ruby/ruby#19606, which has already landed as ruby/ruby@61332e5324.Generated with Claude Code