Conversation
Verify_components.yml workflow ensures components are properly generated ruby-ui/ruby_ui#289 should be merged first Button, Checkbox, Link, Separator, TableFooter, TableRow components were out of sync with ruby_ui.
stephannv
approved these changes
May 12, 2025
| fail-if-not-clean: true | ||
| push-if-not-clean: false | ||
| request-changes-if-not-clean: false | ||
| targets: 'app' #optional |
Contributor
There was a problem hiding this comment.
rails g ruby_ui:component:all can cause changes in Gemfile/Gemfile.lock or js dependencies lock. Do we want to fail the job only if there are changes on component files?
Contributor
Author
There was a problem hiding this comment.
@stephannv , I don't see a reason to be so strict about Gemfile.lock or js dependencies lock.
| with: | ||
| fail-if-not-clean: true | ||
| push-if-not-clean: false | ||
| request-changes-if-not-clean: false |
Contributor
There was a problem hiding this comment.
It would be nice if a PR with the changes was opened so we can review and merge it.
Contributor
Author
There was a problem hiding this comment.
Yeah, it will. Let's do that later on!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verify_components.yml workflow ensures components are properly generated ruby-ui/ruby_ui#289 should be merged first
Button, Checkbox, Link, Separator, TableFooter, TableRow components were out of sync with ruby_ui.
We could try to autocommit the changes later, but I decided to start by only checking for inconsistencies first