Merged
Conversation
pierry01
commented
May 7, 2025
Comment on lines
+39
to
+43
| "whitespace-nowrap inline-flex items-center justify-center rounded-md font-medium transition-colors bg-primary text-primary-foreground shadow", | ||
| "hover:bg-primary/90", | ||
| "disabled:pointer-events-none disabled:opacity-50", | ||
| "focus-visible:outline-none focus-visible:ring-1 focus-visible:ring-ring", | ||
| "aria-disabled:pointer-events-none aria-disabled:opacity-50 aria-disabled:cursor-not-allowed", |
Contributor
Author
There was a problem hiding this comment.
it'd be a good practice to separate the main classes from the pseudo classes triggers
it's more readable and maintainable
stephannv
approved these changes
May 7, 2025
cirdes
reviewed
May 7, 2025
| "hover:underline", | ||
| "disabled:pointer-events-none disabled:opacity-50", | ||
| "focus-visible:outline-none focus-visible:ring-1 focus-visible:ring-ring", | ||
| "aria-disabled:pointer-events-none aria-disabled:opacity-50 aria-disabled:cursor-not-allowed", |
Collaborator
There was a problem hiding this comment.
the code responsible for style de disable look and feel is getting repetead all over the different variants.
It would be nice to define a private constant to define the code and add it here. Something like:
DISABLED_CLASSES = [
"disabled:pointer-events-none disabled:opacity-50",
"aria-disabled:pointer-events-none aria-disabled:opacity-50 aria-disabled:cursor-not-allowed"
] def primary_classes
[
"whitespace-nowrap inline-flex items-center justify-center rounded-md font-medium transition-colors bg-primary text-primary-foreground shadow",
"hover:bg-primary/90",
size_classes,
DISABLED_CLASSES
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on these articles from
developer.mozilla.org | kittygiraudel.com | dhiwise.com | a11y-101.com | dev.to
It's necessary to provide the support for users who want to use
aria-disabledinstead ofdisable