Change destructive foreground color#262
Closed
JMalheiros wants to merge 2 commits intoruby-ui:mainfrom
Closed
Conversation
|
@cirdes or @sethhorsley tagging as this seems like a low hanging fruit |
Member
|
I like this change but I'm closing it because we want to keep this as close to shadcn as possible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to issue Destructive button preview in docs has red text over red background #252
Changed destructive-foreground color to white. It contrasts better with the red from the background.
This constant is used on both Link and Button component, so changed for both of them.
Note: there are two commits on this PR:
WCAG2 comparison between original destructive and destructive-foreground colors:

WCAG2 comparison between slight darker destructive and destructive-foreground colors:

Button and Link with original destructive and destructive-foreground colors:

Button and Link with slight darker destructive and destructive-foreground colors:
