Merged
Conversation
With the upgrade, view_context is only required in Rails applications. Since our use case doesn’t require Rails-specific view helpers, we no longer need to pass view_context.
cirdes
approved these changes
Feb 17, 2025
Collaborator
cirdes
left a comment
cirdes
left a comment
There was a problem hiding this comment.
@karinevieira , It looks good. The ComponentTest is just a class to help us test our code. If it is passing, it should be fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I upgraded the Phlex gem to version 2.0.2, but during the process, the tests started failing with the following error:
After investigating the codebase, I found that support for nil values seems to have been removed.
Additionally, according to the docs,
view_contextis only required in the context of Rails applications, which is not our case. Given that, I removed it.After making this change, the tests started passing again, but I’m not entirely sure if this is the best approach. Any thoughts?