-
Notifications
You must be signed in to change notification settings - Fork 477
Added super_diff gem for improved diffing in tests #953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+4
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Any reason not to require it all the time? |
Contributor
Author
|
@dblock actually, no real reason. It can makes the diffs a bit longer, and if core code has issues the report can grow indefinitely. |
Contributor
|
👍 Nice change, I was also annoyed by how hard the diffs were to parse when working on #951. |
Member
|
CI looks borked :( |
Contributor
Author
Member
|
Rebase this one? |
Contributor
Author
|
@dblock done |
dblock
approved these changes
May 18, 2025
numbata
added a commit
to numbata/grape-swagger
that referenced
this pull request
Dec 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leverage the super_diff gem to significantly enhance the clarity of diffs in failing RSpec tests.
Before:
After: