Repository navigation
deps: Rust 1.99.1, rustler_precompiled 0.10.1, ROCm 7.2.4, and the CI updates - #85
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before
task outdatedonmain:cargo update --dry-runhad three more updates (cc,log,smallvec). CI and the release builds used Rust 1.98.1, Elixir 1.20.4, OTP 29.1.1, ROCm 7.2.3, zizmor 1.30.1, and Task 3.53.1, and five pinned actions had newer releases.Problem
The NIF and CI missed one Rust release, one Elixir and one OTP patch, a ROCm patch, and the action fixes, among them the input handling fix in
dtolnay/rust-toolchain.After
task outdatedreports onlyrustler0.39, which we keep at 0.38.rustler_precompiled(lock)cc(build)log(build)smallvecrustler(crate and Hex)hipblasvariant)actions/upload-artifactactions/download-artifactsoftprops/action-gh-releasetaiki-e/install-actiondtolnay/rust-toolchainmasterat02cb101masterat683b588What we read, what we took, and the checks
cc1.11.0 passes-march=x86-64to GCC on x86_64 Linux when rustc uses its default CPU. Thecmakecrate hands these flags to whisper.cpp, soCMAKE_C_FLAGSnow has-march=x86-64. That is the GCC default on Ubuntu, and ggml still adds its baseline after it: aGGML_NATIVE=OFFbuild on this branch logsAdding CPU backend variant ggml-cpu: -msse4.2;-mf16c;-mfma;-mbmi2;-mavx;-mavx2, the same asmain. A local native build adds-march=nativeafter it, so the local tuning stays. The otherccchanges (source path remaps, CodeView, cl.exe-Tp) do not reach Linux or macOS builds.log0.4.35 has no source change.smallvec1.16.5 only rewraps comments.rustler_precompiled0.10.1 raises the:httpcheader limit to 64 KB, because GitHub redirect headers grew past 10 KB. The requirement stays~> 0.10.0, which allows it, so only the lock moves.rustlerstays at 0.38. 0.39.0 linksenif_*directly on Linux, socargo testdoes not link without a BEAM (deps: rustler 0.39, lru 0.19, and the compatible Rust updates cloaked_req#82).-D warningsfinds nothing new.rust-versionstays 1.98: no dependency asks for more..hip_fatbinsize check guards the build.libcudart.so.12lacks, and CUDA 13 drops thesm_50tosm_70kernels that the README promises.dtolnay/rust-toolchainstays onmaster, because every job names its toolchain. The new commits retry checksum failures and quote the action inputs safely.action-gh-release.Checks on this branch with Rust 1.99.1,
WHISPER_CPP_BUILD=1, andGGML_NATIVE=OFF:task check(format, compile, Credo, Clippy, 62 Elixir tests, 33 Rust tests, zizmor 1.32.0) andtask test:integration(86 tests with real inference) pass.