Simplify by requiring a single expectation - #675
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code partially supported test runner functions returning more than one expectation, which means more than one outcome of each test. But what does it mean to have multiple outcomes for a single test? How can it both pass and fail at the same time? Anyways, at the end we encoded the outcomes into a JSON object keyed by test ID. Duplicate keys in JSON are dropped when parsed, so we threw away all but one outcome.
Turns out test runner functions always return a list with exactly one expectation in practice: elm-explorations/test#244 (reverted because it unfortunately was a breaking change for the package: elm-explorations/test@11f70d5)
This PR simplifies by failing if a test somehow does not return exactly one expectation.