feat(scaffolds): add lint/i18n scaffold - #51
Open
Adi-ty wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Adds a new lint/i18n scaffold to generate a standalone PHPCS ruleset focused on WordPress.WP.I18n, configured with the project’s text domain, and wires a composer lint:i18n script to run it.
Changes:
- Introduces a Mustache template for
phpcs.i18n.xml.distwith stricttext_domainconfiguration and sensible defaults/exclusions. - Adds
scaffold.jsonmanifest to define inputs, composer dev dependencies, and thelint:i18nscript. - Updates the wp-tooling changelog to document the new scaffold.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| node-packages/wp-tooling/scaffolds/lint/i18n/templates/phpcs.i18n.xml.dist.mustache | New standalone PHPCS ruleset template for i18n checks bound to a project text domain. |
| node-packages/wp-tooling/scaffolds/lint/i18n/scaffold.json | New scaffold manifest defining inputs, dependencies, and a lint:i18n composer script. |
| node-packages/wp-tooling/CHANGELOG.md | Documents the addition of the lint/i18n scaffold and its rationale. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+21
to
+29
| "composer_dev_dependencies": { | ||
| "squizlabs/php_codesniffer": "^3.7", | ||
| "wp-coding-standards/wpcs": "^3.0" | ||
| }, | ||
| "scripts": { | ||
| "composer": { | ||
| "lint:i18n": "phpcs --standard=phpcs.i18n.xml.dist" | ||
| } | ||
| } |
Comment on lines
+46
to
+48
| <!-- Installed Claude Code skills ship deliberately-defective eval fixtures; | ||
| linting them reports seeded defects as if they were the project's own. --> | ||
| <exclude-pattern>*/.claude/*</exclude-pattern> |
Comment on lines
+38
to
+39
| <!-- The sniff only reads PHP; limiting extensions keeps CSS/JS out of the run. --> | ||
| <arg name="extensions" value="php"/> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
lint/i18nscaffold: a standalonephpcs.i18n.xml.distrunningWordPress.WP.I18nconfigured with the project's text domain, plus alint:i18ncomposer script. Companion tortCamp/wp-devtools's i18n lens skill (issue #45).