Skip to content

fix(release): ship src/components in the release zip - #83

Open
Adi-ty wants to merge 1 commit into
mainfrom
fix/release-zip-components
Open

Adi-ty wants to merge 1 commit into
mainfrom
fix/release-zip-components

Conversation

@Adi-ty

@Adi-ty Adi-ty commented Nov 10, 2026

Copy link
Copy Markdown
Collaborator

Description

Fixes release ZIPs excluding component PHP required at runtime. Suppress PHPStan’s foreach.emptyArray report after init removes block examples, scoped to Assets.php with reportUnmatched: false.

Technical Details

  • Replace the blanket /src/ exclusion with /src/blocks/, /src/css/ and /src/js/, keeping src/components/.
  • Update packaging documentation and remove the outdated missing-.distignore note.
  • Keep a comment in the static-block array and add a file-scoped PHPStan exception for foreach.emptyArray.

Checklist

  • PHPCS passes (composer lint).
  • Built old/fixed fixture ZIPs using wp-tooling’s zip() function; checked CRC integrity with Python ZipFile.testzip() and extracted with extractall().
  • Old ZIP returns empty markup and triggers the missing-component diagnostic; fixed ZIP renders correctly in WordPress.
  • Fixed ZIP renders the component through the packaged framework loader.
  • Runtime dependencies and built assets remain included; build sources and development files remain excluded.
  • ZIP integrity and whitespace checks pass.
  • PHPStan passes with the updated configuration.

Screenshots

N/A.

To-do

N/A.

Fixes/Covers issue

N/A.

@Adi-ty
Adi-ty marked this pull request as ready for review November 10, 2026 19:58
Copilot AI balanced review requested due to automatic review settings November 10, 2026 19:58

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants