Skip to content

fix(deps): pin webpack-dev-server 6.0.0 and override isomorphic-git 1.38.6 #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aryanjasala merged 2 commits into from
Nov 10, 2026
Merged

fix(deps): pin webpack-dev-server 6.0.0 and override isomorphic-git 1.38.6 #81

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c69ea7c
fix(deps): override isomorphic-git to 1.38.6 for two path-traversal a…
aryanjasala Nov 10, 2026
185e394
fix(deps): pin webpack-dev-server to 6.0.0 to stop the block editor r…
aryanjasala Nov 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/internal/maintenance.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@ The release pull request is opened with `GITHUB_TOKEN`, so GitHub starts no work
| --- | --- | --- |
| `rtcamp/wp-primitives` | `composer.json` (`^2.0`), `composer.lock` | Run `composer update rtcamp/wp-primitives -W`, then `npm run sync-ai` to refresh the generated instructions. Update every pinned docs link (`grep -rn "wp-primitives/blob/v" README.md DEVELOPMENT.md docs`) to the new tag, and review the framework's changelog for anything the examples or docs must follow. |
| `@rtcamp/wp-tooling`, lint configs | `package.json` (`^` ranges on the npm registry), `package-lock.json` | Run `npm update @rtcamp/wp-tooling` (and the configs) to move the lock, then re-run init and scaffold validation. |
| `webpack-dev-server` | `package.json` (`6.0.0` in `devDependencies`, and `overrides` pointing at it) | Pinned below 6.1.0, whose client compares the dev server's combined hash from the two `--experimental-modules` compilers strictly against the page's own hash, so the block editor reloads in a loop under `npm start`. The `overrides` entry alone would nest the pin under `@wordpress/scripts`, where `webpack-cli` cannot find it, so both lines stay. Remove both once a release after 6.1.0 handles multi-compiler hashes, then check that an edit to a block's `edit.js` hot-applies without a reload. |
| Coding standards | `composer.json` (`rtcamp/wp-phpcs`, `rtcamp/wp-phpstan`) | `composer update rtcamp/wp-phpcs rtcamp/wp-phpstan`; fix or baseline new findings in a separate commit. |
| Shared CI | `.github/workflows/test-measure.yml` (`@v1`) | `@v1` moves to compatible v1.x releases on its own. For a new major version, move the ref and check the input names against the new `wp-ci.yml`. |
| Docs builder | `.github/workflows/documentation.yml` (pinned SHA) | See [Documentation publishing](#documentation-publishing). |
Expand Down
29 changes: 22 additions & 7 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 6 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@
"jest-silent-reporter": "0.6.0",
"lint-staged": "17.6.0",
"npm-run-all": "4.1.5",
"webpack-dev-server": "6.0.0",
"webpack-remove-empty-scripts": "1.1.1"
},
"overrides": {
Expand All @@ -68,7 +69,11 @@
},
"@wordpress/scripts": {
"adm-zip": "0.6.1"
}
},
"@wp-playground/storage": {
"isomorphic-git": "1.38.6"
},
"webpack-dev-server": "$webpack-dev-server"
},
"scripts": {
"build:dev": "cross-env NODE_ENV=development npm-run-all 'build:!(dev|prod)'",
Expand Down
Loading