Repository navigation
docs: follow up on the review notes from #77 - #80
Merged
Merged
Conversation
Adi-ty
approved these changes
Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Picks up Aditya's non-blocking notes on #77, which merged without them so the 1.0.1 release could go out tonight. Docs and comments only, no behaviour change.
Changes
webpack.blocks.config.jsanddocs/hmr.mdsaid the wrapper exists because webpack-dev-server v5, pinned throughoverrides, rejects the object-formproxywp-scripts emitted. Since fix(deps): update @wordpress/scripts to 37 and refresh stale npm overrides #77 that pin is gone and wp-scripts 37 runs webpack-dev-server 6 with an array-form proxy. The wrapper still removes it, for a different reason: the/buildproxy target is hardcoded tolocalhost:8887(the theme's default port), so with this plugin's 8886 or any customBLOCKS_DEV_SERVER_PORTit points at another server. The comments and docs now say that.docs/internal/maintenance.mdgets a Dependency updates row for@wordpress/theme4.0.0: why it is a direct dev dependency (the@wordpress/stylelint-configpeer thatlegacy-peer-depsdoes not install), and how to bump it.How I verified
@wordpress/scripts37.0.0'sconfig/webpack.config.js: the dev server'sproxyis[ { context: [ '/build' ], target: 'http://localhost:8887', ... } ].package-lock.jsononmainresolveswebpack-dev-server6.1.0, with no override.npm view @wordpress/stylelint-config@27 peerDependencieslists@wordpress/themeas^3.0.0 || ^4.0.0.node --check webpack.blocks.config.js; only comments changed in it.Reviewer notes
The split
@wordpress/themeversions in the lockfile and the older scaffold requirements are a separate compatibility check; tracked in #79.