fix: add initialized state to CarouselContext to track carousel initialization#92
Merged
theMasudRana merged 2 commits intodevelopfrom Mar 26, 2026
Merged
fix: add initialized state to CarouselContext to track carousel initialization#92theMasudRana merged 2 commits intodevelopfrom
theMasudRana merged 2 commits intodevelopfrom
Conversation
…alization Resolves: #78
theMasudRana
previously approved these changes
Mar 24, 2026
Collaborator
There was a problem hiding this comment.
The changes look good to me.
Tested from my end for the following points:
- No breaking changes
- Updates the state correctly when the loop is true.
- Updates the state correctly when free drag is enabled.
- Updates the state correctly when scroll snap is used.
theMasudRana
approved these changes
Mar 26, 2026
Collaborator
theMasudRana
left a comment
theMasudRana
left a comment
There was a problem hiding this comment.
Tested after the last push.
Everything looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates
aria-current="true"for the slides as well when it changes.Type of change
Related issue(s)
Closes #78
What changed
Added an internal flag to check for the Embla initialization before
isSlideActivecallback.Breaking changes
Does this introduce a breaking change? If yes, describe the impact and migration path below.
Testing
Describe how this was tested.
Test details:
Screenshots / recordings
If applicable, add screenshots or short recordings.
Checklist