Refactor docker targets to allow running with no image update - #1038
Open
matsl wants to merge 1 commit into
Open
Refactor docker targets to allow running with no image update#1038matsl wants to merge 1 commit into
matsl wants to merge 1 commit into
Conversation
* Makefile (docker-latest, docker-run-latest): Update image if needed
before running the docker job.
(docker, docker-run): Remove dependency on update so targets can
be used with no automated update check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Refactor docker targets to allow running with no image update.
before running the docker job.
(docker, docker-run): Remove dependency on update so targets can
be used with no automated update check.
Why
When on a slow network it becomes a burden to force an update of the
Emacs docker image. It can take a really long time. The updates seems
to be on a daily basis, possibly due to the images being rebuilt on a
daily frequency. But for old Emacsen that does not make much sense.
To get the latest docker image either a manual update with make
docker-update can be used or the new targets docker-latest or
docker-run-latest that does an image update.