chore: migrate linting to rslint and prettier#448
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5bcc22d15a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Pull request overview
Migrates the repo’s root linting/formatting workflow from Biome to Rslint + Prettier, updates editor recommendations, and applies formatting changes across examples so the new checks pass.
Changes:
- Add root
rslint.config.ts,.prettierrc,.prettierignore; removebiome.json. - Update root scripts and
lint-stagedto runrslint+prettier, and update VS Code formatter/recommendations. - Reformat a broad set of JS/TS/JSON/config files to align with Prettier settings (single quotes, printWidth 100).
Reviewed changes
Copilot reviewed 52 out of 66 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| rspack/worker-inline/rspack.config.mjs | Prettier-style formatting (quotes) in config. |
| rspack/react-ssr-esm/client/components/app.tsx | Quote normalization. |
| rspack/react-ssr-esm/client/client.tsx | Quote normalization + semicolons consistent with Prettier. |
| rspack/javascript-api/src/index.ts | Parameter formatting/trailing comma alignment. |
| rspack/http-import/rspack.config.mjs | Minor spacing/quote formatting. |
| rspack/emotion/src/index.jsx | Template literal indentation formatting. |
| rspack/dll/c.tsx | Quote normalization. |
| rspack/dll/beta.ts | Add missing semicolon + quote normalization. |
| rspack/dll/b.ts | Quote normalization. |
| rspack/dll/alpha.ts | Quote normalization. |
| rspack/dll/a.ts | Quote normalization. |
| rspack/dll-reference/index.js | Add semicolons + normalize import statements. |
| rspack/css-chunking-plugin/src/page.js | Quote normalization + semicolon insertion. |
| rspack/css-chunking-plugin/src/index.js | Quote normalization. |
| rspack/code-splitting/rspack.config.mjs | Quote normalization. |
| rspack/case-sensitive-paths-webpack-plugin/rspack.config.mjs | Quote normalization. |
| rspack/bundle-splitting/rspack.config.mjs | Quote normalization. |
| rspack/basic/rspack.config.mjs | Quote normalization. |
| rslint.config.ts | Introduce root Rslint configuration and ignore patterns. |
| rslib/web-worker/tsconfig.json | Formatting-only JSON changes. |
| rslib/web-worker/src/worker.ts | Formatting-only change. |
| rslib/web-worker/src/index.ts | Formatting-only change. |
| rslib/umd/src/components/CounterButton/index.tsx | JSX prop formatting condensation. |
| rslib/solid/tsconfig.json | Formatting-only JSON changes. |
| rslib/solid/src/Button.tsx | Quote normalization + object key quoting. |
| rslib/react-tailwindcss/src/index.tsx | Quote normalization + line wrapping. |
| rslib/react-tailwindcss/postcss.config.mjs | Formatting-only change. |
| rslib/react-tailwindcss-v3/src/index.tsx | Quote normalization + line wrapping. |
| rslib/react-sass/src/useCounter.tsx | Quote normalization. |
| rslib/react-sass/src/index.tsx | Quote normalization. |
| rslib/react-less/src/useCounter.tsx | Quote normalization. |
| rslib/react-less/src/index.tsx | Quote normalization. |
| rslib/react-less/rslib.config.ts | Quote normalization. |
| rslib/react-css-module/src/useCounter.tsx | Quote normalization. |
| rslib/react-css-module/src/index.tsx | Quote normalization. |
| rslib/react-css-module/src/components/CounterButton/index.tsx | JSX prop formatting condensation + quote normalization. |
| rslib/preact/tsconfig.json | Formatting-only JSON changes. |
| rslib/preact/src/Button.tsx | Quote normalization. |
| rslib/node-basic/src/subtract.ts | Formatting-only change. |
| rslib/node-basic/src/multiply.ts | Formatting-only change. |
| rslib/node-basic/src/index.ts | Formatting-only change. |
| rslib/node-basic/src/divide.ts | Formatting-only change. |
| rslib/node-basic/src/add.ts | Formatting-only change. |
| rslib/module-federation/mf-react-component/src/CounterButton.tsx | JSX prop formatting condensation. |
| rslib/module-doc/tsconfig.json | Whitespace cleanup. |
| rslib/module-doc/tsconfig.build.json | Formatting-only change. |
| rslib/module-doc/src/Button.tsx | Quote normalization. |
| rslib/module-doc/rspress.config.ts | Quote normalization. |
| rslib/module-doc/rslib.config.ts | Quote normalization. |
| rslib/iife/src/index.ts | Indentation normalization. |
| rsbuild/ssr-express/prod-server.mjs | Quote normalization. |
| rsbuild/ssr-express-with-manifest/prod-server.mjs | Quote normalization + minor line wrapping. |
| rsbuild/shadcn-ui/src/components/ui/button.tsx | Interface extends formatting condensation. |
| rsbuild/react-eslint/.eslintrc.cjs | Quote normalization. |
| rsbuild/fastify/server.mjs | Quote normalization. |
| rsbuild/express/server.mjs | Quote normalization. |
| pnpm-workspace.yaml | Quote style normalization. |
| pnpm-lock.yaml | Replace Biome with @rslint/core + add Prettier dependency; lock updates. |
| package.json | Add lint/lint:write, update lint-staged to rslint+prettier, swap devDependencies. |
| biome.json | Remove Biome configuration. |
| README.md | Table whitespace formatting update. |
| AGENTS.md | Update contributor guidance to reference Rslint/Prettier; whitespace. |
| .vscode/settings.json | Switch default formatter to Prettier. |
| .vscode/extensions.json | Recommend Rslint + Prettier extensions. |
| .prettierrc | Add Prettier config (singleQuote, printWidth 100). |
| .prettierignore | Add Prettier ignore patterns for artifacts/generated files. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
Validation