Repository navigation
chore(deps): update dependency @swc-next/parser to ^0.5.0 - #133
Merged
Merged
Conversation
0.5.0 added an errorRecovery option (swc-project/swc-next#1247) whose default now throws the first diagnostic as a plain object instead of returning diagnostics in the parse result. parseTestFile relied on the recovery behavior, so its SyntaxError check no longer fired and the "should reject invalid syntax" unit test failed. Pass errorRecovery: true to keep the 0.4.x behavior, and throw SyntaxError from the returned error diagnostic as before. Cover-grammar resolution from expression nodes (#1150) does not change any AST shape the test walk relies on (diffed 0.4.1 vs 0.5.0 program trees on representative test-file patterns; unit suite green).
fi3ework
enabled auto-merge (squash)
November 9, 2026 07:33
macOS E2E flaker: e2e/rstest/suite/progress.test.ts saw failedMessages[2] be "after suite" instead of the inline-snapshot failure, with all 5 messages present (failedMessages.length === 5). Root cause an upstream core gap, not a race in our code. @rstest/core's worker-side sink (k~0.js onTestCaseResult in 0.12.6) hands our reporter each case result only after the previous delivery's extension-host response, and suite results bypass that chain entirely: they fan out as soon as the runner hook returns, right after afterAll — while a case emitted before the hook may still be queued inside core, not yet handed to us. With the extension host slow to answer, the suite hook failure then posts past still-pending failing case results of the same file, and the editor publishes run.failed in arrival order. Because core cannot tell us what is still queued, no post-time ordering we can derive stays faithful: any "wait for what we have seen" gate misses the unseen case (the false green of the first attempt's chain). Fix in ProgressReporter (stacks/test/worker/reporter.ts): defer suite results into a per-testPath queue at delivery time and flush them (in emission order) just before the file result posts. Core fans the file result out only after its case chain drained, so the flush point is the one moment every preceding case result is known-delivered, and the master always sees [cases..., suites..., file]. onTestRunEnd flushes leftovers so a torn-down attempt loses nothing queued; a new attempt's onTestFileStart/onTestFileReady (core re-runs a file only after a worker SIGKILL retry) drops the previous attempt's queue. Suite results no longer acknowledge the extension host at delivery time, so the ported upstream unit test drops that assertion (documented with a comment); it keeps the case/file-result assertions verbatim, and three new unit tests pin the order under core's pacing, the run-end flush and the attempt-boundary drop — the order test fails against the arrival-order delivery (reproduced) and passes here. Upstream fixed this at the sink level for 1.0 by joining all file-scoped deliveries before onTestFileResult (#1875); runnerEventSink joins case deliveries only in our pinned 0.12, so the deferral is ours. Documented as ahead-of-upstream bug fix (7) in packages/vscode/AGENTS.md to offer back when syncing.
fi3ework
added a commit
that referenced
this pull request
Nov 9, 2026
* chore(deps): update dependency @swc-next/parser to ^0.5.0 * fix(vscode): adapt to @swc-next/parser 0.5.0 0.5.0 added an errorRecovery option (swc-project/swc-next#1247) whose default now throws the first diagnostic as a plain object instead of returning diagnostics in the parse result. parseTestFile relied on the recovery behavior, so its SyntaxError check no longer fired and the "should reject invalid syntax" unit test failed. Pass errorRecovery: true to keep the 0.4.x behavior, and throw SyntaxError from the returned error diagnostic as before. Cover-grammar resolution from expression nodes (#1150) does not change any AST shape the test walk relies on (diffed 0.4.1 vs 0.5.0 program trees on representative test-file patterns; unit suite green). --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: fi3ework <fi3ework@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
^0.4.1→^0.5.0Release Notes
swc-project/swc-next (@swc-next/parser)
v0.5.0Compare Source
🚀 Features
🐛 Bug Fixes
🚜 Refactor
📚 Documentation
⚡ Performance
{before mapped-type lookahead (#1179)⚙️ Miscellaneous Tasks
Configuration
📅 Schedule: (UTC)
* 0-3 * * 1)🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.