Skip to content

feat(fmt): add serial runner - #121

Merged
chenjiahan merged 1 commit into
mainfrom
chenjiahan/feat-fmt-serial-runner
Jul 31, 2026
Merged

feat(fmt): add serial runner#121
chenjiahan merged 1 commit into
mainfrom
chenjiahan/feat-fmt-serial-runner

Conversation

@chenjiahan

Copy link
Copy Markdown
Member

Summary

This PR adds the serial execution primitive for the future rs fmt pipeline. It accepts resolved per-file Prettier options, supports write, check, and list-different modes with structured results, and continues after per-file failures with stable exit-code precedence. Writes use bundled atomically, while the minimal code derived from @prettier/cli includes the required license and third-party notices; cache, workers, CLI wiring, and public exports remain out of scope.

Related Links

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying rstack-cli with  Cloudflare Pages  Cloudflare Pages

Latest commit: 13e758a
Status: ✅  Deploy successful!
Preview URL: https://779332d7.rstack-cli.pages.dev
Branch Preview URL: https://chenjiahan-feat-fmt-serial-r.rstack-cli.pages.dev

View logs

@coderabbitai

coderabbitai Bot commented Jul 31, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 1290263f-2bcc-46df-800d-bfe1f7601b0c

📥 Commits

Reviewing files that changed from the base of the PR and between fba323c and 13e758a.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (9)
  • packages/rstack/THIRD_PARTY_NOTICES.md
  • packages/rstack/package.json
  • packages/rstack/src/fmt/runner.ts
  • packages/rstack/src/fmt/types.ts
  • packages/rstack/src/fmt/vendor/prettier-cli/LICENSE
  • packages/rstack/src/fmt/vendor/prettier-cli/serial.ts
  • packages/rstack/tests/fmt/runner.test.ts
  • packages/rstack/tests/fmt/runnerWriteFailure.test.ts
  • pnpm-workspace.yaml

📝 Walkthrough

Walkthrough

Added public formatter execution types and a serial formatter that reads, formats, compares, and optionally writes files atomically. Added runFmtFiles with per-file results, timing, error handling, and aggregate exit codes. Added tests for write, check, list-different, permissions, processing errors, and write failures. Added dependency metadata and third-party license notices.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: adding a serial formatter runner.
Description check ✅ Passed The description directly explains the serial formatter runner, supported modes, error handling, atomic writes, and scope.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chenjiahan/feat-fmt-serial-runner

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chenjiahan
chenjiahan merged commit 6338a31 into main Jul 31, 2026
4 checks passed
@chenjiahan
chenjiahan deleted the chenjiahan/feat-fmt-serial-runner branch July 31, 2026 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant