feat(fmt): respect gitignore files - #118
Conversation
|
Warning Review limit reached
Next review available in: 24 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying rstack-cli with
|
| Latest commit: |
1a3c1fc
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5d5cb5a0.rstack-cli.pages.dev |
| Branch Preview URL: | https://chenjiahan-feat-fmt-gitignor.rstack-cli.pages.dev |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1a3c1fcfe9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // Ignore files may disappear or become unreadable during traversal. | ||
| const loading = readFile(path.join(directoryPath, '.gitignore'), 'utf8') | ||
| .then((content) => { | ||
| this.#matchers.set(directoryPath, ignore().add(content)); |
There was a problem hiding this comment.
In a case-sensitive repository (core.ignoreCase=false, the usual Linux setting), a .gitignore entry such as generated.ts does not ignore Generated.ts, but ignore() defaults to case-insensitive matching. Directory and glob formatting therefore silently omit differently-cased files that Git considers unignored; configure the matcher using the repository's core.ignoreCase behavior instead of accepting the package default.
Useful? React with 👍 / 👎.
1 participant
Directory and glob formatting should follow repository ignore rules without requiring a Prettier ignore file. This PR loads nested
.gitignorefiles from the Git repository root, preserves Git negation semantics, and lets explicitly named files bypass.gitignore. It bundlesignore@7.0.5with the required license notice.