Skip to content

feat(fmt): add ignore patterns matcher - #116

Merged
chenjiahan merged 1 commit into
mainfrom
chenjiahan/feat-fmt-ignore-patterns
Jul 30, 2026
Merged

feat(fmt): add ignore patterns matcher#116
chenjiahan merged 1 commit into
mainfrom
chenjiahan/feat-fmt-ignore-patterns

Conversation

@chenjiahan

@chenjiahan chenjiahan commented Jul 30, 2026

Copy link
Copy Markdown
Member

This PR adds a reusable in-memory matcher for define.fmt.ignorePatterns so discovered and explicitly passed files share the same gitignore-compatible filtering.

It uses fast-ignore@2.0.0 as a bundled dev dependency, compiles each config's ordered patterns once, and resolves file paths from the Rstack config root

Related Links

@coderabbitai

coderabbitai Bot commented Jul 30, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@chenjiahan, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 20 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: f9a0a8a1-72c1-44ec-b984-dcfeb6d3e5c1

📥 Commits

Reviewing files that changed from the base of the PR and between 06d4704 and 57db227.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (5)
  • packages/rstack/THIRD_PARTY_NOTICES.md
  • packages/rstack/package.json
  • packages/rstack/src/fmt/ignore.ts
  • packages/rstack/tests/fmt/ignore.test.ts
  • pnpm-workspace.yaml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying rstack-cli with  Cloudflare Pages  Cloudflare Pages

Latest commit: 57db227
Status: ✅  Deploy successful!
Preview URL: https://4e4e4016.rstack-cli.pages.dev
Branch Preview URL: https://chenjiahan-feat-fmt-ignore-p.rstack-cli.pages.dev

View logs

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 57db227a5f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/rstack/src/fmt/ignore.ts
@chenjiahan
chenjiahan merged commit e117493 into main Jul 30, 2026
4 checks passed
@chenjiahan
chenjiahan deleted the chenjiahan/feat-fmt-ignore-patterns branch July 30, 2026 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant