Skip to content

feat(fmt): normalize formatter config - #111

Merged
chenjiahan merged 1 commit into
mainfrom
chenjiahan/feat-normalize-fmt-config
Jul 30, 2026
Merged

feat(fmt): normalize formatter config#111
chenjiahan merged 1 commit into
mainfrom
chenjiahan/feat-normalize-fmt-config

Conversation

@chenjiahan

Copy link
Copy Markdown
Member

Summary

This PR introduces an internal normalized formatter config model so later rs fmt stages can consume project context, shared Prettier options, per-file overrides, and ignore patterns separately.

It adds a pure config transformation without I/O, config factory execution, or public exports.

@coderabbitai

coderabbitai Bot commented Jul 30, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 749d537c-ff80-430d-8765-d1c04a7e7140

📥 Commits

Reviewing files that changed from the base of the PR and between ef1daec and 2555374.

📒 Files selected for processing (2)
  • packages/rstack/src/fmt/config.ts
  • packages/rstack/src/fmt/types.ts

📝 Walkthrough

Walkthrough

Adds the exported ResolvedFmtConfig interface with Prettier options, root path, overrides, and ignore patterns. Adds and exports normalizeFmtConfig, which converts an optional FmtConfig into this resolved shape and defaults missing overrides and ignore patterns to empty arrays.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: normalizing formatter config.
Description check ✅ Passed The description is on-topic and describes the normalized formatter config model for rs fmt.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chenjiahan/feat-normalize-fmt-config

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chenjiahan
chenjiahan merged commit 023edfd into main Jul 30, 2026
3 of 4 checks passed
@chenjiahan
chenjiahan deleted the chenjiahan/feat-normalize-fmt-config branch July 30, 2026 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant