chore: resolve Dependabot alerts in example and test dependencies - #152
Conversation
- morgan 1.12.1 in the three epic-stack examples (was pinned to 1.11.0) - pnpm overrides for adm-zip 0.6.1 (Module Federation node runtime in the federation example) and joi 17.13.6 / 18.2.5 (wait-on in the test harness) None of these are dependencies of the published plugin, so no release is needed.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
commit: |
Benchmark results
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6e1be6de9f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -0,0 +1 @@ | |||
| {"schema":1,"isBuild":false,"appDirectory":"/fast/projects/rsbuild-plugin-react-router/app","outputClientPath":"/fast/projects/rsbuild-plugin-react-router/build/client","routes":{"root":{"path":"","id":"root","file":"root.tsx"},"routes/index":{"id":"routes/index","parentId":"root","file":"routes/index.tsx","index":true}},"assetPrefix":"/","snapshot":{"browser":{"version":"recovered","url":"/assets/manifest-recovered.js","entry":{"module":"/assets/entry-recovered.js","imports":[],"css":[]},"routes":{}},"moduleExportsByRouteId":{},"server":{"version":"recovered","url":"/assets/manifest-recovered.js","entry":{"module":"/assets/entry-recovered.js","imports":[],"css":[]},"routes":{}},"serverByBundleId":{},"serverByEntryName":{"static/js/react-router-server-build":{"version":"recovered","url":"/assets/manifest-recovered.js","entry":{"module":"/assets/entry-recovered.js","imports":[],"css":[]},"routes":{}}}}} No newline at end of file | |||
There was a problem hiding this comment.
This file is a build/test cache artifact containing hard-coded /fast/projects/... paths and recovered placeholder data. Because the directory hash is derived from the absolute application and output paths, another checkout will use a different cache entry and will never consume or refresh this tracked file. Remove it and ignore the generated react-router/ cache directory to prevent stale, machine-specific manifests from accumulating in source control.
Useful? React with 👍 / 👎.
Merging this PR will not alter performance
Comparing 
Footnotes
|
1 participant
Summary
Resolves the 10 open Dependabot alerts. All of them are in example or test tooling, not the published plugin, so there is no changeset and no release.
morgan1.12.1 inexamples/epic-stack,examples/federation/epic-stack, andexamples/federation/epic-stack-remote(previously pinned to 1.11.0).adm-zip@<0.6.1→^0.6.1(pulled in by@module-federation/nodein the federation example), replacing the earlier<0.6.0override.joi@17→^17.13.6andjoi@18→^18.2.5(pulled in bywait-onin the test harness).Verification
pnpm typecheckandpnpm buildpass.pnpm exec rstest run: one early run reported 10 failures in one file; three later consecutive runs passed with 0 failures.examples/epic-stackandexamples/federationbuild;morgan1.12.1 loads and builds a middleware in all three epic-stack examples.wait-on(react-router-serve-test,loader-context-test,spa-mode-test): 52 passed.