chore: build before stage publish#77
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: aa02e134ed
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| run: pnpm i | ||
|
|
||
| - name: Build Packages | ||
| run: pnpm build |
There was a problem hiding this comment.
Define a build script before running it
In this repository package.json has no scripts.build entry (I checked the only package.json with rg --files -g 'package.json'), so this newly added release step will stop every tag/dispatch publish before pnpm stage publish runs. pnpm documents that pnpm run runs a script from the package manifest and that --if-present is needed to avoid a non-zero exit when the script is undefined, so either add the build script or don't call it in this workflow.
Useful? React with 👍 / 👎.
Summary
pnpm stage publish.scripts.preparewhere present.Validation
pnpm build.git diff --check.