Skip to content

chore: build before stage publish#77

Closed
chenjiahan wants to merge 3 commits into
mainfrom
codex/build-before-stage-publish
Closed

chore: build before stage publish#77
chenjiahan wants to merge 3 commits into
mainfrom
codex/build-before-stage-publish

Conversation

@chenjiahan

Copy link
Copy Markdown
Member

Summary

  • Build packages in the release workflow before pnpm stage publish.
  • Remove duplicate build commands from scripts.prepare where present.

Validation

  • Verified staged publish workflows have a preceding pnpm build.
  • Ran git diff --check.

@chenjiahan chenjiahan marked this pull request as ready for review May 29, 2026 12:57

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: aa02e134ed

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/release.yml Outdated
run: pnpm i

- name: Build Packages
run: pnpm build

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Define a build script before running it

In this repository package.json has no scripts.build entry (I checked the only package.json with rg --files -g 'package.json'), so this newly added release step will stop every tag/dispatch publish before pnpm stage publish runs. pnpm documents that pnpm run runs a script from the package manifest and that --if-present is needed to avoid a non-zero exit when the script is undefined, so either add the build script or don't call it in this workflow.

Useful? React with 👍 / 👎.

@chenjiahan chenjiahan closed this May 30, 2026
@chenjiahan chenjiahan deleted the codex/build-before-stage-publish branch May 30, 2026 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant