Merged
Conversation
Switch from Parser::CurrentRuby to Prism::Translation::Parser for future-proof Ruby 4.0+ syntax support. Parser::CurrentRuby silently falls back to Ruby33 parser on Ruby 4.0 since the parser gem doesn't know about it yet. - Replace Parser::CurrentRuby with Prism::Translation::Parser - Use Prism::Translation::Parser::Builder as default builder - Add explicit prism runtime dependency - Add Ruby 4.0 to CI matrix - Bump version to 2.1.0 Co-authored-by: Cursor <cursoragent@cursor.com>
3 tasks
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment Thanks for integrating Codecov - We've got you covered ☂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Parser::CurrentRubytoPrism::Translation::Parserfor future-proof Ruby 4.0+ syntax supportParser::CurrentRubysilently falls back toParser::Ruby33since theparsergem doesn't know about Ruby 4.0 yet. This works for now but won't handle Ruby 4.0-specific syntax.Prism::Translation::Parseris a drop-in replacement (extendsParser::Base, same interface) and uses Ruby's built-in Prism parserPrism::Translation::Parser::Builderas default builder (avoids deprecation warning)prismruntime dependency (was already a transitive dependency viaunparser)Test plan
Made with Cursor