Repository navigation
perf(gpu): reuse Canny horizontal storage for state flags - #186
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Canny's horizontal rows are dead after the vertical gradient pass. Reuse that same atomic state/flag binding for packed rows, then overwrite it only after all gradients finish. Remove the separate horizontal buffer/binding and unused aperture-3 dummy. Requested private scratch becomes 16*N bytes for every aperture with three storage buffers; full parent indices, exact gradients/edges, five/six passes, metadata, stage destination receipts and explicit image transfers retain behavior.
At 4K, apertures 5/7 save another 33,177,600 private bytes (165,888,000 to 132,710,400); aperture 3 removes eight bytes. Two isolated surveys give 1.040–1.215x completed resident improvements across the tested 4K fixtures. All full-call 4K intervals include one; a Full HD full-call case has an adverse interval. Default pool/driver/resource behavior is included, so shader-only or general-device speedup is not claimed. All 20 rows and limitations are in notes/2026-10-13_gpu_canny_reuse_horizontal_state.md.
Validation: