Repository navigation
perf(features): parallelize ISS keypoints with bounded CPU workers - #149
Merged
Merged
Conversation
rsasaki0109
changed the base branch from
codex/parallel-boundary-detection
to
main
October 12, 2026 02:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ISS detection previously evaluated every covariance and local maximum on the caller.
feature-issnow shares one KD-tree across bounded scoped CPU workers, joining the saliency phase before selection reads it. Parallel selection writes a temporary one-byte-per-point mask and collects indices in input order; small/one-worker calls keep direct serial index collection. Public signatures, per-point math, equal-maxima behavior, schema, attributes and metadata are preserved.Validation: 1,081,992 exact selection decisions and selected clouds against the frozen serial API; independent covariance eigenvalues, tied maxima and degenerate support; all six attribute buffer types including signed-zero/NaN words; configuration, empty/singleton and concurrent-call parity. Seven minimal and twenty-three all-feature native tests plus one facade smoke pass. Strict minimal/all-feature Clippy, crate/facade WASM compilation, formatting and diff checks pass.
Completed
detectmeasurements include selected XYZ copying, using twelve conditions, two warmups and twenty rotating paired rounds. All six 32,768/65,536-point conditions favor public staging by 1.41–2.54x. Adverse one-worker controls at 16,384 and 32,768 noisy curved points are retained; serial neutrality and fixed cross-machine speedups are not claimed.Execution boundary and all measurement conditions.