Repository navigation
Validate bounded native keyframe tracking against four TUM sequences - #126
Merged
Merged
Conversation
…ane-validation # Conflicts: # CHANGELOG.md
…ane-validation # Conflicts: # CHANGELOG.md
rsasaki0109
marked this pull request as ready for review
October 12, 2026 01:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retaining a keyframe can preserve geometric support while producing an incorrect trajectory. Add explicit bounded static, input-overlap and coarse-SVD/fine-plane study adapters, with permanent tracking failure, typed attributes, one world gauge and exact protocol/helper/native hashes. The default estimator is unchanged.
Four official TUM sequences retain preregistered conditions, references withheld until estimates freeze, and all failed/missing poses. All 12 new study/comparison cases fail at least one unchanged coverage/accuracy condition. Desk2 hybrid ATE/RPE is 1.045931/0.179715 m versus the plane baseline's 0.523587/0.102466 m. Maturity remains 87%, provisional; measured canonical clock/mounting calibration and broad accurate-motion gates remain open.
Repair two confirmed integration-test defects without changing production algorithms: wait for complete HTTP headers within the existing 4 KiB bound, and explicitly restore blocking mode on accepted sockets. The macOS failed-job log identifies EOF in both fragmented-request tests. Forcing nonblocking accepted sockets reproduces both failures on Linux before repair; both then pass with unchanged strict HEAD/no-body and exact 206/range assertions.
Validation:
See docs/TUM_KEYFRAME_VALIDATION.md and notes/2026-10-12_copc_accepted_socket_regression.md for evidence and limits. Main PRs #122–#146 are preserved. Raw archives, images, point-cloud dumps and native binaries remain local. Attribution: TUM RGB-D Benchmark, Sturm et al. (IROS 2012), CC BY 4.0.
Delivery verification (2026-10-12T01:46:30.100741+00:00):
The exact head 921d285 has 54/107 main jobs successful and all seven required wheel jobs successful. The repaired macOS Streaming job, Linux/Windows Streaming, full-feature tests/Clippy, Python and ONNX verification all succeed. 53 main jobs remain queued without assigned runners. The planned complete 107+7 gate remains incomplete; delivery retains this limitation rather than marking queued jobs passed. The fresh main candidate tree equals the tested head tree (43ec6e7eb0f2e7cbfd7768c6d8a5b27aacdae22c). Maturity remains 87%, provisional, with physical accuracy/calibration gates open.