Repository navigation
bump to rquickjs 0.14 - #5
Merged
Merged
Conversation
Member
|
@svix-jbrown The blob was unsound but not because of the transmute mainly because the engine can mutate the pointer. We don't have a choice but to make a copy since we can yield to the engine in some cases. I dropped the older versions and improved the general code while I was at it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am almost positive that the CFFI code here is unsound and results in UB because it transmutes a
*mut u8into a*const u8while other references are live.Every module except the
sqliteone should be fine, though.Part of #4