chore(renovate): stop lock file maintenance from bumping biome ahead - #133
Merged
Merged
Conversation
…of schema lockFileMaintenance re-resolves the lockfile to the newest version allowed by package.json's semver range, but it doesn't run the customManagers step that keeps biome.json's $schema pin in sync. That let @biomejs/biome drift to 2.5.8 in pnpm-lock.yaml while biome.json still declared 2.5.5, which biome treats as a hard error (#118). Excluding @biomejs/biome from lockFileMaintenance means its resolved version can only change via the dedicated "update dependency @biomejs/biome" PR, which updates biome.json in the same commit.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a6060c9259
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…eMaintenance Codex flagged that lockFileMaintenance regenerates the whole lockfile as a single synthetic update rather than per-package, so a packageRule scoped by matchPackageNames + matchUpdateTypes: ["lockFileMaintenance"] never actually matches and doesn't stop biome from drifting. Pinning the range instead removes the room to drift in the first place: with rangeStrategy "pin", @biomejs/biome's resolved version can only move when Renovate rewrites the exact pin itself, which happens in the same grouped "biome" PR that updates biome.json's $schema.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…of schema
lockFileMaintenance re-resolves the lockfile to the newest version allowed by package.json's semver range, but it doesn't run the customManagers step that keeps biome.json's $schema pin in sync. That let @biomejs/biome drift to 2.5.8 in pnpm-lock.yaml while biome.json still declared 2.5.5, which biome treats as a hard error (#118).
Excluding @biomejs/biome from lockFileMaintenance means its resolved version can only change via the dedicated "update dependency @biomejs/biome" PR, which updates biome.json in the same commit.