fix(biome): bump schema pin to 2.5.8 and drop deprecated property - #132
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d9942a6f5e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "$schema": "https://biomejs.dev/schemas/2.5.5/schema.json", | |||
| "$schema": "https://biomejs.dev/schemas/2.5.8/schema.json", | |||
There was a problem hiding this comment.
CI installs dependencies with --frozen-lockfile, and pnpm-lock.yaml:14-16 still resolves Biome 2.5.5. The quick-verification workflow then runs biome check ., where this 2.5.8 schema produces Biome's incompatible-schema configuration error before linting, so every CI run is blocked. Update the dependency and lockfile to 2.5.8 together with this schema change, or retain the 2.5.5 schema.
AGENTS.md reference: AGENTS.md:L398-L398
Useful? React with 👍 / 👎.
d9942a6 to
828fab5
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 828fab5a31
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| '@playwright/test': | ||
| specifier: ^1.61.1 | ||
| version: 1.62.0 | ||
| version: 1.62.1 |
There was a problem hiding this comment.
When CI reaches the E2E step, this installs Playwright 1.62.1 while .github/workflows/ci.yml:13-14 still runs inside mcr.microsoft.com/playwright:v1.62.0-noble; that workflow explicitly requires the image to stay synchronized with the lockfile. Playwright's Docker documentation warns that mismatched versions can prevent Playwright from locating the browser executables, which would also invalidate the Chromium path resolved later for Lighthouse. Update the container tag alongside this lockfile entry.
Useful? React with 👍 / 👎.
…erty Lock file maintenance resolved @biomejs/biome to 2.5.8 within the existing ^2.5.3 range, but biome.json's $schema still pinned 2.5.5, which biome treats as a hard error. The newer version's CSS-in-SVG linting also flags the deprecated enable-background property in favicon.svg, which has no effect in modern browsers.
Codex flagged that this branch's lockfile still resolved biome 2.5.5 while biome.json's schema now pins 2.5.8 - the branch never included the actual lock-file-maintenance bump, just a schema change written against it. Rebuilt on top of that lockfile bump (#118) so the resolved version and schema agree, and pinned the range exactly so future lockFileMaintenance runs can't drift the resolved version past the schema again (see the matching renovate.json change).
828fab5 to
4357ec6
Compare
Codex review on this PR (pullrequestreview-5003390451) flagged the same class of bug as the biome one: the lock-file-maintenance bump resolved @playwright/test to 1.62.1 while ci.yml's container image was still pinned to v1.62.0-noble, which the comment above it says must stay in sync. Bumped the image tag to match, and pinned @playwright/test to an exact version (matching the renovate.json "playwright" group's rangeStrategy) so lockFileMaintenance can't drift it away from the pinned image again.
1 participant
Lock file maintenance resolved @biomejs/biome to 2.5.8 within the existing ^2.5.3 range, but biome.json's $schema still pinned 2.5.5, which biome treats as a hard error. The newer version's CSS-in-SVG linting also flags the deprecated enable-background property in favicon.svg, which has no effect in modern browsers.