Repository navigation
Emit executor execute tracepoint from shared entity paths - #3368
Open
Quchaosheng wants to merge 1 commit into
Open
Quchaosheng wants to merge 1 commit into
Quchaosheng wants to merge 1 commit into
Conversation
Signed-off-by: Chaosheng Qu <chaosheng.qu.linux@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ordinary executors emit
rclcpp_executor_executefromExecutor::execute_any_executable().EventsCBGExecutorcalls the sharedexecute_subscription()/execute_timer()methods directly, so tracing consumers do not see the corresponding execution events.This moves the existing timer and subscription tracepoints into those shared execution methods. Ordinary executors retain the same tracepoint semantics,
EventsCBGExecutorgains parity, and the deprecatedEventsExecutoralso emits the subscription tracepoint through the same path. No duplicate tracepoints are introduced.Service/client/waitable tracepoints are intentionally not added because the ordinary executor path does not emit them today.
Validation
Rpr__rclcpp__ubuntu_resolute_amd64: passed (compile and test).