Repository navigation
Backports - #99
Merged
Merged
Backports #99
Conversation
ahcorde
commented
Oct 20, 2026
ahcorde
commented
Contributor
- Use NodeInterfaces for tf2_ros constructors
- Use extras_require for turtle_tf2_py test dependencies
- Include what you use
- Update Lyrical CI
- Python warning
geometry2 0.46.2 removed the deprecated tf2_ros constructors that took a node pointer or separate node interfaces (ros2/geometry2#940), which breaks the rolling binary build for this package. Pass the node itself instead: rclcpp::node_interfaces::NodeInterfaces has an implicit constructor taking a node reference. Assisted-by: Claude Opus 5 <noreply@anthropic.com> Signed-off-by: Michael Carroll <mjcarroll.oss@gmail.com>
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
mjcarroll
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.