Use sip-build and python3_add_library for Qt5/Qt6#157
Use sip-build and python3_add_library for Qt5/Qt6#157
Conversation
Signed-off-by: Shane Loretz <sloretz@intrinsic.ai>
Signed-off-by: Shane Loretz <sloretz@intrinsic.ai>
|
|
Signed-off-by: Shane Loretz <sloretz@intrinsic.ai>
Signed-off-by: Shane Loretz <sloretz@intrinsic.ai>
Signed-off-by: Shane Loretz <sloretz@intrinsic.ai>
Signed-off-by: Shane Loretz <sloretz@intrinsic.ai>
Signed-off-by: Shane Loretz <sloretz@intrinsic.ai>
Signed-off-by: Shane Loretz <sloretz@intrinsic.ai>
Signed-off-by: Shane Loretz <sloretz@intrinsic.ai>
This updates the branch to use this PR: ros-visualization/python_qt_binding#157 And it also completely disables shiboken support, since it appears to be broken as packaged in Debian and Ubuntu: * https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1131536 * https://bugs.launchpad.net/ubuntu/+source/pyside6/+bug/2146611 Signed-off-by: Shane Loretz <sloretz@intrinsic.ai>
Signed-off-by: Shane Loretz <sloretz@intrinsic.ai>
Signed-off-by: Shane Loretz <sloretz@intrinsic.ai>
Signed-off-by: Shane Loretz <sloretz@intrinsic.ai>
|
Pulls: ros-visualization/rqt#339, ros-visualization/qt_gui_core#293, #157 |
|
Related with ros2/ci#857 and ros2/ros2#1810 |
Signed-off-by: Shane Loretz <sloretz@intrinsic.ai>
I'm playing around with an alternative to #143.
Requires ros/rosdistro#50338
If I understand correctly, and I'm not sure that I do,
python_qt_bindinguses a Python scriptsip_configure.pyto produce a Makefile that produces a cPython extension.#143 uses sip-build, but sets it up to use
pip installto generate the bindings. It ends up creating a separate functionbuild_sip_6_bindingto use this new approach with a configurable pyproject.toml.in template downstream inqt_gui_core.This PR uses
sip-buildand the CMake functionpython3_add_libraryto build a cPython extension instead. This PR allows using sip-build on both Qt5 and Qt6 bindings, though right now I've only tested it with Qt5 on Noble. I'll need to update the Python code like @ahcorde has in #143 to import from PyQt6.I used Gemini 3.1 Pro to help make this PR