Refactor transcript handling and improve output messaging#75
Merged
Conversation
- Moved transcript-related functionality from runner to a dedicated transcript module. - Introduced `createPushgateTranscript` to encapsulate different transcript types. - Updated `runDeterministicChecks` to accept a transcript parameter instead of stdout. - Enhanced output messages for local AI review and deterministic checks to provide clearer guidance. - Added tests to validate new transcript functionality and ensure proper output formatting. - Removed deprecated `transcript.ts` file and consolidated its functionality into the new structure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the handling of transcript (developer-facing output) for both the Deterministic and Local AI review phases, introducing a unified, language-agnostic transcript module and updating documentation to reflect this architectural change. The main improvements are the introduction of the
src/transcriptmodule, migration of transcript event rendering out of the AI module, and consistent transcript streaming across phases.Transcript system refactor and documentation update:
src/transcriptmodule that owns language-agnostic, developer-facing output for both Deterministic and Local AI review phases, replacing phase-specific transcript logic. [1] [2] [3] [4]transcriptobject instead of a rawstdoutstream, and to use the new transcript interface for streaming output events. [1] [2] [3] [4] [5] [6] [7] [8]renderLocalAiTranscriptand transcript event types fromsrc/ai/transcript.tsandsrc/ai/types.ts, moving transcript event types to the new module. [1] [2] [3] [4]docs/architecture/overview.md,docs/architecture/modules.md,docs/architecture/runtime-flow.md) to document the new transcript module, its responsibilities, and integration points in the architecture and runtime flow. [1] [2] [3] [4] [5] [6] [7] [8] [9]