Add support for ignoring specific exceptions#14
Open
tomaj wants to merge 2 commits intorootpd:masterfrom
Open
Conversation
This change adds a new 'ignore_exceptions' configuration option that allows
filtering out specific exception types from being sent to Sentry while still
logging them locally via Tracy.
Use case:
In production environments with background workers (e.g., Hermes message queue
workers), graceful shutdown is triggered via SIGTERM signal during deployments.
This causes ShutdownException to be thrown, which is normal and expected
behavior. However, these exceptions were being logged to Sentry, creating
noise in error monitoring.
With this change, you can configure exceptions to ignore:
sentry:
ignore_exceptions:
- Tomaj\Hermes\Shutdown\ShutdownException
Ignored exceptions are still logged to Tracy's local log files but won't
be sent to Sentry, reducing noise and improving signal-to-noise ratio in
error monitoring.
- Suppress deprecation warning from ninjify/nunjuck using @ operator (nunjify/nunjuck uses deprecated lcg_value() function in PHP 8.4+) - Fix ApplicationMonitor hook to check if application.application service exists before trying to access it (fixes tests that don't register application service)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a new
ignore_exceptionsconfiguration option that allows filtering out specific exception types from being sent to Sentry while still logging them locally via Tracy.Motivation
In production environments with background workers (e.g., Hermes message queue workers), graceful shutdown is triggered via SIGTERM signal during deployments. This causes
ShutdownExceptionto be thrown as part of the normal shutdown process. However, these exceptions were being logged to Sentry, creating noise in error monitoring and making it harder to identify actual issues.Changes
ignore_exceptionsconfig option toSentryExtensionsetIgnoredExceptions()method toSentryLoggerlog()method to skip sending ignored exceptions to SentryUsage
Ignored exceptions will still be logged to Tracy's local log files but won't be sent to Sentry.
Benefits