Repository navigation
[IR-6585] docs: support --services and --types on incidents - #84
Merged
Merged
Conversation
…ate/update (docs only; flags shipped in #55) Co-authored-by: soil-cloud[bot] <344511034+soil-cloud[bot]@users.noreply.github.com>
Co-authored-by: soil-cloud[bot] <344511034+soil-cloud[bot]@users.noreply.github.com>
Contributor
|
Soil is watching this PR. It acts on CodeFlow's review of the latest commit, review comments and change requests, red CI (after checking
|
[Low impact] This documentation-only PR appears safe to merge. SummaryUpdates
No actionable issues found. The documented flags match the command code and existing tests. Tests were inspected, not run. Reviews (1) · Last reviewed commit: "docs: reference rootly pulse create --se..." · Reviewed by Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Ticket: IR-6585
What changed
N/A
Proof
Verified at
0839c603dbed: no harness test run at HEAD, lint passed, 0/4 criteria proved at HEAD (4 awaiting re-proof), council approved · proofs · Soil laneCriteria at
0839c603dbed, each on what the harness ran or captured:rootly incidents create --title=... --services=a,b --types=csends service_ids and incident_type_i… — not proved: the evidence judge found the harness output does not show it: The proofs do not address this criterion at all.rootly incidents update <id> --services=... --types=...sends them only when the flag is passed an… — not proved: the evidence judge found the harness output does not show it: The proofs do not address this criterion at all.go vetpassing for internal/api and internal/cmd/incidents (exit=0), which says nothing about whether code changed, whether update.go is untouched, or what the PR body states.Existing tests for create/update associations and INC-123 normalisation pass; diff is README.md only; --help lists every flag the README names:
References: IR-6824, IR-6586, IR-6584, IR-5478, IR-6588, IR-6585, IR-5846
Risk: low
Overrides
57534c36ca, by the operator: the finding is wrong for this lane. The six URLs are separate tickets, each with its own lane and PR (IR-6824 → rootlyhq/rootly#26389, IR-5846 → rootlyhq/rootly#26390, IR-6586 → [IR-6586] feat(02-03): warn when resolving an incident from the CLI #83, IR-6584 → ir-6584-304657; IR-5478 and IR-6588 were already done upstream). The human asked for one — overrode: these parts of the ask have no acceptance criterion: "https://linear.app/rootly/issue/IR-6824/mcp-claude-desktop-and-claude-code-sdk-cannot-connect-the-mcp-server"; "https://linear.app/rootly/issue/IR-6586/cli-add-status-page-commands-incidents-update-statusresolved-leaves"; "https://linear.app/root26ecc5e1f9, by the operator: this check doesn't apply. The change is README.md only (+23 lines, no Go code), documenting flags that already shipped with tests in rootly-cli#55. There is no behaviour for a harness test or prove_fix to show. The run captured at HEAD 26ecc5e (environment exec log) shows the diff is README-only and — overrode: acceptance criterion AC1 is not proved: it cites only files the lane wrote (tmp/soil/proofs/verify.txt, tmp/soil/environment/exec-mw2mjiw0-e02499026a21.log), not anything the harness ran or captured. A criterion is proved only by something the harness ran or captured at HEAD — a harness test run (it; acceptance criterion AC2 is not proved: it cites only files the lane wrote (tmp/soil/proofs/verify0839c603db, by the operator: this re-applies my 26ecc5e override at HEAD 0839c60. The change is still README.md only, with no Go code, documenting association flags that shipped with tests in rootly-cli#55. No harness test or prove_fix can go red before and green after for a docs change. go vet passes at HEAD and the existing c — overrode: Verify proof missing: acceptance criteria proved at HEAD (AC1, AC2, AC3, AC4 not yet)Full run report: council review, criteria, every capture and output.