Repository navigation
Conversation
Signed-off-by: Eduard Zateev <hackerowskiy@gmail.com>
sairex53
force-pushed
the
fix-536-accept-retry
branch
from
October 22, 2026 11:25
272da50 to
b1cb280
Compare
Member
Did you test it with an actual instance of Docker, nerdctl, or something else? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the parent TCP listener hits EMFILE or ENFILE, the current accept loop closes newConns, causing the port-forwarding worker to exit. The listener then stops forwarding connections permanently even after descriptors become available.
Retry these descriptor-exhaustion errors with capped exponential backoff, reset the delay after a successful accept, and make the wait interruptible during shutdown. Other accept errors retain the existing behavior.
Add tests for recovery after EMFILE and ENFILE, prompt shutdown during the retry delay, and termination on a non-retryable accept error.
Fixes #536.
Testing: