Skip to content

Potential fix for 1 code quality finding #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
vizsatiz wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

Potential fix for 1 code quality finding #183

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 15 additions & 19 deletions ...console/floconsole/db/alembic/versions/2025_12_13_1400-a1b2c3d4e5f6_create_default_app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,27 +32,23 @@ def upgrade() -> None:
if default_app_name and default_app_public_url and default_app_private_url:
# Check if a default app already exists with the same name
conn = op.get_bind()
# Insert default app
# Insert default app using SQLAlchemy Table reflection for better type safety
app_id = uuid.uuid4()
conn.execute(
sa.text("""
INSERT INTO app (id, app_name, public_url, private_url, deleted, status, config, deployment_type, type, created_at, updated_at)
VALUES (:id, :app_name, :public_url, :private_url, :deleted, :status, :config, :deployment_type, :type, :created_at, :updated_at)
"""),
{
'id': app_id,
'app_name': default_app_name,
'public_url': default_app_public_url,
'private_url': default_app_private_url,
'deleted': False,
'status': 'success',
'config': '{}',
'deployment_type': 'manual',
'type': 'custom',
'created_at': datetime.now(),
'updated_at': datetime.now(),
},
app_table = sa.Table('app', sa.MetaData(), autoload_with=conn)
insert_stmt = app_table.insert().values(
id=app_id,
app_name=default_app_name,
public_url=default_app_public_url,
private_url=default_app_private_url,
deleted=False,
status='success',
config='{}',
deployment_type='manual',
type='custom',
created_at=datetime.now(),
updated_at=datetime.now(),
)
conn.execute(insert_stmt)


def downgrade() -> None:
Expand Down