[RF,geom,TMVA] avoid shadowing parent class members - #23062
Conversation
Test Results 23 files 23 suites 5d 3h 56m 55s ⏱️ For more details on these failures, see this check. Results for commit 086b2b0. |
| Int_t *fNdivisions; // [fNrows] number of divisions for each row | ||
| Double_t *fStart; // [fNrows] starting points for each row | ||
| Int_t *fNdivs; // [fNrows] number of divisions for each row | ||
| Double_t *fRowStart; // [fNrows] starting points for each row |
There was a problem hiding this comment.
This does not appear to be backward compatible in term of reading old file. Are we missing I/O customization rules? Can we add tests?
There was a problem hiding this comment.
Original issue #8189 describes the problem.
Once duplicated name for class member introduced in the class - we have no easy way to make I/O conversion rule for it.
To resolve issue we need first to implement I/O conversion rules for such cases and only then modify mentioned classes.
There was a problem hiding this comment.
Also: to prevent new occurrences in the future, should we turn on this warning? https://stackoverflow.com/a/59047305/7471760
I have no idea about I/O conversion rules so I'll leave this PR as draft in case someone wants to take over ;)
4 participants
Closes #8189