[curl] Reject multipart parts spanning range gaps - #23052
Open
laxmanacharya8 wants to merge 1 commit into
Open
Conversation
Test Results 23 files 23 suites 3d 13h 56m 48s ⏱️ For more details on these failures, see this check. Results for commit f31481d. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reject a multipart byte-range part that would continue into a non-adjacent requested range. Previously, a malformed response such as
Content-Range: bytes 0-19/...could fill requests for0-9and100-109, silently writing bytes 10-19 into the second buffer.Adjacent ranges remain supported because the HTTP request preprocessor coalesces them intentionally.
Add a loopback HTTP regression test that sends the malformed multipart response and verifies that the transfer fails before the second range is written.
Testing
git diff --check