[ntuple] Allow enabling RNTupleMetrics through env variable - #23038
Open
albfsg wants to merge 2 commits into
Open
[ntuple] Allow enabling RNTupleMetrics through env variable#23038albfsg wants to merge 2 commits into
albfsg wants to merge 2 commits into
Conversation
albfsg
requested review from
bellenot,
dpiparo,
jblomer and
silverweed
as code owners
August 6, 2026 12:20
silverweed
reviewed
Aug 6, 2026
Contributor
|
Please rename the PR to something a bit more specific like |
enirolf
reviewed
Aug 6, 2026
albfsg
changed the title
albfsg
force-pushed
the
metrics_expansion
branch
from
August 7, 2026 07:44
5640691 to
4814af8
Compare
albfsg
force-pushed
the
metrics_expansion
branch
2 times, most recently
from
August 7, 2026 12:25
0b6924f to
7373c8b
Compare
Test Results 23 files 23 suites 3d 17h 36m 26s ⏱️ For more details on these failures, see this check. Results for commit 6b687ea. ♻️ This comment has been updated with latest results. |
In this commit, `ROOT_EXPORT_RNTUPLE_METRICS` is an optional environment variable that if set enables the metrics, but does not trigger metric storage after the program ends. In a future commit, we will expect the optional environment variable `ROOT_EXPORT_RNTUPLE_METRICS` to be set to a path. If done, metrics will be enabled and RNTupleMetrics will store the metrics there as a `.root` file.
albfsg
force-pushed
the
metrics_expansion
branch
from
August 10, 2026 08:11
7373c8b to
6b687ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request:
Changes or fixes: <- Changes
ROOT_EXPORT_RNTUPLE_METRICS.ROOT_EXPORT_RNTUPLE_METRICSand updated the counters unit tests.It's a first step towards improving the usability of the
RNTupleMetricsclass.Checklist:
ROOT_EXPORT_RNTUPLE_METRICSin the header of theRNTupleMetricsclassThis PR fixes # <- Nothing