[Python][CodeQL] Clean up unused loop iteration variables#22707
Open
siliataider wants to merge 1 commit into
Open
[Python][CodeQL] Clean up unused loop iteration variables#22707siliataider wants to merge 1 commit into
siliataider wants to merge 1 commit into
Conversation
guitargeek
reviewed
Jun 25, 2026
| # Tests | ||
| def test_basic_type_branch(self): | ||
| f,t,c = self.get_tree_and_chain() | ||
| _,t,c = self.get_tree_and_chain() |
Contributor
There was a problem hiding this comment.
Not sure if this is correct here. Don't we need to keep the file around explicitly because it's the owner of t and c?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request:
Changes or fixes:
Minor cleanup: CodeQL flags loop variables that are never used inside the loop
Just renaming unused loop/unpack variables to
_