Skip to content

[cmake] Correct two typos with potential serious consequences #22704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dpiparo wants to merge 3 commits into
base: master
Choose a base branch
from
+3 −3
Open

[cmake] Correct two typos with potential serious consequences #22704

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
40df1bb
[cmake] Spell builtin_zlib correctly
dpiparo Jun 25, 2026
2812545
[tut] Spell correctly tutorial file name for the veto
dpiparo Jun 25, 2026
a0dadb8
[nfc] Typo in comment
dpiparo Jun 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion builtins/ftgl/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ target_compile_definitions(FTGL::FTGL INTERFACE FTGL_LIBRARY_STATIC) # needed fo
if(builtin_freetype)
add_dependencies(BUILTIN_FTGL BUILTIN_FREETYPE)
endif()
if(builin_zlib)
if(builtin_zlib)
add_dependencies(BUILTIN_FTGL BUILTIN_ZLIB)
endif()
target_link_libraries(FTGL::FTGL INTERFACE Freetype::Freetype) # private: OpenGL::GL OpenGL::GLU ZLIB::ZLIB
Expand Down
2 changes: 1 addition & 1 deletion tree/ntuple/src/RMiniFile.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -594,7 +594,7 @@ struct RBareFileHeader {
};
#pragma pack(pop)

/// The artifical class name shown for opaque RNTuple keys (see TBasket)
/// The artificial class name shown for opaque RNTuple keys (see TBasket)
constexpr char const *kBlobClassName = "RBlob";
/// The class name of the RNTuple anchor
constexpr char const *kNTupleClassName = "ROOT::RNTuple";
Expand Down
2 changes: 1 addition & 1 deletion tutorials/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ if(NOT mathmore)
math/mathmoreIntegration.C
math/pdf/pdf007_multivarGaus.C
math/pdf/pdf012_tStudent.C
math/pdf/pdf001_Nornal.C
math/pdf/pdf001_Normal.C
roofit/roostats/TestNonCentral.C
roofit/roostats/TestNonCentral.py
math/Legendre.py
Expand Down
Loading