Add GH20033 regression test for joined processors#22702
Open
matildamarjamaki wants to merge 1 commit into
Open
Add GH20033 regression test for joined processors#22702matildamarjamaki wants to merge 1 commit into
matildamarjamaki wants to merge 1 commit into
Conversation
vepadulano
requested changes
Jun 25, 2026
vepadulano
left a comment
vepadulano
left a comment
Member
There was a problem hiding this comment.
Thank you! I have left some minor comments to improve the layout of the test, the changes already look quite good.
|
|
||
| using GH20033ProcessorConfig = std::tuple<bool, bool, bool, bool>; | ||
|
|
||
| class GH20033ProcessorTest : public testing::TestWithParam<GH20033ProcessorConfig> { |
Member
There was a problem hiding this comment.
As we did in the other PR, I think it would be good here to include a comment linking this test to the equivalent TTree test introduced by #20222
| "gh20033_rntuple_stepzero_1.root" | ||
| }; | ||
|
|
||
| // Muut analyysivaiheet omissa tiedostoissaan |
Member
There was a problem hiding this comment.
Before merging it would be good to translate comments to English
Comment on lines
+1039
to
+1041
| std::unique_ptr<RNTupleProcessor> CreateStepProcessor(std::string_view ntupleName, | ||
| const std::string &fileName, | ||
| bool useChain) |
Member
There was a problem hiding this comment.
Suggested change
| std::unique_ptr<RNTupleProcessor> CreateStepProcessor(std::string_view ntupleName, | |
| const std::string &fileName, | |
| bool useChain) | |
| std::unique_ptr<RNTupleProcessor> CreateStepProcessor(std::string_view ntupleName, | |
| std::string_view fileName, | |
| bool useChain) |
Just for consistency, let's use std::string_view for both arguments. Or equivalently you can use const std::string & for both
| { | ||
| if (useChain) { | ||
| std::vector<RNTupleOpenSpec> specs{{std::string(ntupleName), fileName}}; | ||
| return RNTupleProcessor::CreateChain(specs, std::string(ntupleName)); |
Member
There was a problem hiding this comment.
Suggested change
| return RNTupleProcessor::CreateChain(specs, std::string(ntupleName)); | |
| return RNTupleProcessor::CreateChain(specs); |
as per the documentation
processorName The name to give to the processor. If empty, the name of the input RNTuple is used.
| return RNTupleProcessor::CreateChain(specs, std::string(ntupleName)); | ||
| } | ||
|
|
||
| return RNTupleProcessor::Create({std::string(ntupleName), fileName}, std::string(ntupleName)); |
Member
There was a problem hiding this comment.
Suggested change
| return RNTupleProcessor::Create({std::string(ntupleName), fileName}, std::string(ntupleName)); | |
| return RNTupleProcessor::Create({std::string(ntupleName), fileName}); |
as per the documentation
processorName The name to give to the processor. If empty, the name of the input RNTuple is used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request:
Changes or fixes:
Checklist:
This PR fixes #