[cmake] mv glad to builtins#22697
Conversation
|
Hi! FYI, glad is not a builtin dependency. It's code auto-generated by the tool with the same name. Since the code generation was customized to bring exactly what ROOT needs, and the whole idea of glad is that you just copy-paste the generated code into your project, I wouldn't consider this code a "builtin dependency". |
In my opinion: yes and no. Why do I advocate to put in the builtins folder ? Because it was generated externally. This way, if they fix something in the upstream version such as Dav1dde/glad@cef3f89 If twice a year we say let's update all our builtins for upstream fixes, we won't forget about glad. If it's deep inside graf3d, we will for sure forget. Getting the overview in a single folder is relevant in my opinion. |
Test Results 22 files 22 suites 2d 13h 59m 58s ⏱️ For more details on these failures, see this check. Results for commit 252d01d. |
For consistency with other hard-coded builtins such as afterimage and mathtext